Skip to content

stream improvment - page splitter #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 10, 2019

Conversation

mariuszs
Copy link
Contributor

@mariuszs mariuszs commented Feb 9, 2019

No description provided.

@mariuszs mariuszs force-pushed the feature/295-page-splitter branch 2 times, most recently from c178300 to 70d9767 Compare February 9, 2019 12:05
@mariuszs mariuszs force-pushed the feature/295-page-splitter branch 3 times, most recently from 36c17ea to 1756992 Compare February 9, 2019 22:51
@mariuszs mariuszs force-pushed the feature/295-page-splitter branch from 1756992 to 8787d80 Compare February 9, 2019 22:53
@gmessner
Copy link
Collaborator

@mariuszs
You captured the lazy Stream idea perfectly. Let me know when you are done, I will then merge and make some documentation updates to better describe and explain things around the Stream implementation. If I do the documentation updates in a PR, would you have time to review for me?

@mariuszs
Copy link
Contributor Author

mariuszs commented Feb 10, 2019 via email

@gmessner
Copy link
Collaborator

@mariuszs
Looks great, thanks for working with me on this. I'll have a PR for the docs within the next day or so, will let you know when it's ready.

@gmessner gmessner merged commit 0085d12 into gitlab4j:master Feb 10, 2019
@mariuszs mariuszs deleted the feature/295-page-splitter branch March 22, 2019 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants