Java 8 Stream Documentation improvements #298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariuszs
reviewed
Feb 10, 2019
mariuszs
reviewed
Feb 10, 2019
mariuszs
reviewed
Feb 10, 2019
| ```java | ||
| // Stream the visible Projects printing out the project name. | ||
| gitlabApi.getProjectsApi().getProjectsStream().map(Project::getName).forEach(name -> System.out.println(name)); | ||
| Stream projectsStream<Project> = gitlabApi.getProjectApi().getProjectsStream(); | ||
| projectsStream.map(Project::getName).forEach(name -> System.out.println(name)); | ||
|
|
||
| // Operate on the stream in parallel, this example sorts User instances by username |
There was a problem hiding this comment.
I'm not sure if this is a good idea to give such an example here. Parallel operations are generally used for performance optimization, but here project gathering is so slow, that this operation doesn't add any improvement. As a result, the user can be confused that this operation can be super fast and this library can fetch data in multiple channels.
There was a problem hiding this comment.
Parallel operations are often performed after fetching the data, parallel operations are not only used to speed up fetching, I have added more info to make the fact that reading of the data for the Stream cannot be done in parallel.
mariuszs
reviewed
Feb 10, 2019
mariuszs
reviewed
Feb 10, 2019
mariuszs
reviewed
Feb 10, 2019
mariuszs
approved these changes
Feb 11, 2019
|
@mariuszs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarifies the use of Streams for both eager and lazy evaluation uses.