Skip to content

Add support for email on push integration. #662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 22, 2021

Conversation

ttaxon
Copy link
Contributor

@ttaxon ttaxon commented Feb 23, 2021

This adds support for the Emails on push integration.

Copy link
Collaborator

@jabby jabby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR. I didn't try your patch yet.
Here are few remarks. Can you please take care of them?

}

/**
* Updates the Custom Issue Tracker service settings for a project.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update javadoc accordingly to gitlab documentation? https://docs.gitlab.com/ee/api/services.html#emails-on-push

@ttaxon
Copy link
Contributor Author

ttaxon commented Mar 3, 2021

All edits have been made.

@jabby jabby added this to the 4.16.0 milestone Mar 13, 2021
@jabby
Copy link
Collaborator

jabby commented Mar 22, 2021

Thanks @ttaxon
I will provide some automated tests in another PR

@jabby jabby merged commit d155674 into gitlab4j:master Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants