Skip to content

Add more field to NoteEvent.ObjectAttributes #670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 11, 2021

Conversation

yuezhuangshi
Copy link
Contributor

This pull request adds more field to NoteEvent.ObjectAttributes

Currently, the data structure of NoteEvent.ObjectAttributes is consistent with the offical document , but after testing, I found that the actual data structure of NoteEvent.ObjectAttributes has more field, and I need discussion_id and type field for custom purposes.

"object_attributes": {
    "attachment": null,
    "author_id": 1234,
    "change_position": null,
    "commit_id": null,
    "created_at": "2021-03-16 16:39:18 UTC",
    "discussion_id": "56e2b4210419aed077d47ca2dc00551c7c4ac882",
    "id": 351809,
    "line_code": null,
    "note": "/tbd 12321 12321",
    "noteable_id": 2344,
    "noteable_type": "Issue",
    "original_position": null,
    "position": null,
    "project_id": 2072,
    "resolved_at": null,
    "resolved_by_id": null,
    "resolved_by_push": null,
    "st_diff": null,
    "system": false,
    "type": "DiscussionNote",
    "updated_at": "2021-03-16 16:39:18 UTC",
    "updated_by_id": null,
    "description": "/tbd 12321 12321",
    "url": "http://xx.xx.xx.xx/xyxy/abc/issues/1#note_351809"
  }

@yuezhuangshi
Copy link
Contributor Author

@jabby Cloud you please review this PR and release a version ASAP?

@jabby jabby added this to the 4.16.0 milestone Mar 22, 2021
@jabby
Copy link
Collaborator

jabby commented Mar 22, 2021

@yuezhuangshi Thanks for your PR. I will review it for the 4.16 milestone. No release date defined yet. There is no snapshot build either actually but are you interested in a 4.16-snapshot? If so, I will create a snapshot really soon.

@yuezhuangshi
Copy link
Contributor Author

yuezhuangshi commented Mar 25, 2021

@jabby Can you release a version gitlab4j-api-4.15.8 with this PR?

@jabby jabby merged commit 57a7cc5 into gitlab4j:master Apr 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants