Skip to content

add missing reviewers related fields to MergeRequestEvent webhook event #879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

tabilzad
Copy link

@tabilzad tabilzad commented Nov 30, 2022

This PR will add the missing reviewers fields to the MergeRequestEvent

  • List<Reviewer> reviewers at top level of MergeRequestEvent.java
  • List<Long> reviewerIds to ObjectAttributes of MergeRequestEvent.java

https://docs.gitlab.com/ee/user/project/integrations/webhook_events.html#merge-request-events

@mifitous
Copy link
Contributor

mifitous commented Feb 16, 2023

Hi @tabilzad
Any chance we can merge this one?
It is blocking me to provide support to https://github.com/jenkinsci/gitlab-branch-source-plugin
Thanks

@tabilzad
Copy link
Author

@jabby could u assist with this one, not sure why the pipeline is failing for testExportDownloadAndImport. The PR is just adding new fields to data classes

@jmini
Copy link
Collaborator

jmini commented Apr 4, 2023

In my opinion this can be closed after the merge of #916.

If not, feel free to re-open…

@jmini jmini closed this Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants