Skip to content

Added queued_duration for Pipelines and Jobs #930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 12, 2023

Conversation

Macariel
Copy link
Contributor

queued_duration is a valid field for Jobs and Piplines.

Copy link
Collaborator

@jmini jmini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has unnecessary code-formatting changes, but looks good to me

Copy link
Collaborator

@jmini jmini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following tests are failing:

Error:  Failures: 
Error:    TestGitLabApiBeans.testPipeline:392 expected: <true> but was: <false>
Error:    TestGitLabApiEvents.testPipelineEvent:124 expected: <true> but was: <false>
Error:    TestGitLabApiEvents.testPolymorphicEvent:218 expected: <true> but was: <false>

@Macariel
Copy link
Contributor Author

Tests should be fixed :-)

@Macariel Macariel requested a review from jmini March 28, 2023 07:42
Copy link
Collaborator

@jmini jmini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Thank you very much for this contribution.

@jabby jabby merged commit 3407ec9 into gitlab4j:main Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants