This repository was archived by the owner on May 30, 2024. It is now read-only.
Add a new license type for OSS #186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahingh
added
the
component: server
noahingh
changed the title
noahingh
changed the title
noahingh
commented
Oct 29, 2021
Comment on lines
+40
to
+42
| Kind: LicenseKindOSS, | ||
| MemberCount: -1, | ||
| DeploymentCount: -1, |
There was a problem hiding this comment.
The IsOverLimit of the OSS License always returns false.
| func (l *License) IsOverLimit() bool { | ||
| return l.MemberCount > l.MemberLimit | ||
| return l.MemberCount > l.MemberLimit || l.DeploymentCount > l.DeploymentLimit |
There was a problem hiding this comment.
Add deployment limit to verify the license.
Comment on lines
+37
to
+40
| if lic.IsOSS() { | ||
| return | ||
| } | ||
|
|
There was a problem hiding this comment.
Skip when the license is oss
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a new license type,
OSS, avoids the API being blocked by the limit of license.