Skip to content
This repository was archived by the owner on May 30, 2024. It is now read-only.

Fix the short ref bug #305

Merged
merged 2 commits into from
Jan 9, 2022
Merged

Fix the short ref bug #305

merged 2 commits into from
Jan 9, 2022

Conversation

noahingh
Copy link
Member

@noahingh noahingh commented Jan 9, 2022

No description provided.

@noahingh noahingh added the bug Something isn't working label Jan 9, 2022
@noahingh noahingh added this to the v0.5 milestone Jan 9, 2022
@noahingh noahingh linked an issue Jan 9, 2022 that may be closed by this pull request
* @returns
*/
export const getShortRef = (deployment: Deployment): string => {
return deployment.type === DeploymentType.Commit? deployment.ref.substring(0, 7) : deployment.ref
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mutate the ref for the commit type.

@noahingh noahingh marked this pull request as ready for review January 9, 2022 01:55
@noahingh noahingh merged commit 2828f4e into main Jan 9, 2022
@noahingh noahingh deleted the fix-short-ref branch January 9, 2022 01:56
noahingh pushed a commit that referenced this pull request Jan 9, 2022
* Fix the short ref bug
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A bug for the format of ref of browser notification
1 participant