Skip to content
This repository was archived by the owner on May 30, 2024. It is now read-only.

Fix the dynamic payload validation to skip a rollback #445

Merged
merged 1 commit into from
Jun 12, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions internal/interactor/validator.go
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,10 @@ type DynamicPayloadValidator struct {
}

func (v *DynamicPayloadValidator) Validate(d *ent.Deployment) error {
if d.IsRollback {
return nil
}

if !v.Env.IsDynamicPayloadEnabled() {
return nil
}
Expand Down
10 changes: 10 additions & 0 deletions internal/interactor/validator_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -138,3 +138,13 @@ func TestSerializationValidator_Validate(t *testing.T) {
}
})
}

func TestDynamicPayloadValidator_Validate(t *testing.T) {
t.Run("Returns nil if it is rollback.", func(t *testing.T) {
v := &i.DynamicPayloadValidator{Env: &extent.Env{}}

if err := v.Validate(&ent.Deployment{IsRollback: true}); err != nil {
t.Fatalf("Validate returns an error: %s", err)
}
})
}