Skip to content

Fix local-ssh not work in vscode insider #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 1, 2024
Merged

Fix local-ssh not work in vscode insider #102

merged 2 commits into from
Feb 1, 2024

Conversation

mustard-mh
Copy link
Contributor

Description

electron seems remove support for --ms-enable-electron-run-as-node flags in vscode insider It will cause electron not to swallow this flags, resulting in a change in our parameter position.

image

Related Issue(s)

Fixes #

How to test

  1. build a extension using this branch and install it in both vscode insider and vscode stable, and restart vscode
  2. try to open workspace via vscode insider and vscode stable
  3. check remote hostname, it should be *.vsi.* or *.vss.*

Documentation

/hold

@mustard-mh mustard-mh marked this pull request as draft January 31, 2024 07:22
@mustard-mh mustard-mh marked this pull request as ready for review January 31, 2024 08:00
@mustard-mh mustard-mh requested a review from jeanp413 January 31, 2024 16:27
@jeanp413
Copy link
Member

Ref microsoft/vscode#202053

@jeanp413 jeanp413 merged commit 4ee2f66 into master Feb 1, 2024
@jeanp413 jeanp413 deleted the hw/fix-insider branch February 1, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants