[ws-proxy] provide a hint to our future selves (#17009)

kylos101 · web-flow · commit 049ebe15421b · 2023-03-23T23:29:16.000+01:00
diff --git a/components/ws-proxy/cmd/run.go b/components/ws-proxy/cmd/run.go
@@ -128,7 +128,9 @@ var runCmd = &cobra.Command{
 			grpcOpts := common_grpc.DefaultClientOptions()
 			grpcOpts = append(grpcOpts, dialOption)
 
+			log.Info("Attempting to dial ws-manager, it's a blocking call that retries...")
 			conn, err := grpc.Dial(wsm.Addr, grpcOpts...)
+			// you will never get here if ws-manager is crashing, instead the readiness check for ws-proxy will restart the pod
 			if err != nil {
 				log.WithError(err).Fatal("cannot connect to ws-manager")
 			}

Original file line number	Diff line number	Diff line change
`@@ -128,7 +128,9 @@ var runCmd = &cobra.Command{`
`128`	`128`	`grpcOpts := common_grpc.DefaultClientOptions()`
`129`	`129`	`grpcOpts = append(grpcOpts, dialOption)`
`130`	`130`
	`131`	`+ log.Info("Attempting to dial ws-manager, it's a blocking call that retries...")`
`131`	`132`	`conn, err := grpc.Dial(wsm.Addr, grpcOpts...)`
	`133`	`+ // you will never get here if ws-manager is crashing, instead the readiness check for ws-proxy will restart the pod`
`132`	`134`	`if err != nil {`
`133`	`135`	`log.WithError(err).Fatal("cannot connect to ws-manager")`
`134`	`136`	`}`