Skip to content

[ws-proxy] log before attempting to dial ws-manager #17009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 23, 2023

Conversation

kylos101
Copy link
Contributor

@kylos101 kylos101 commented Mar 23, 2023

Description

Adding a quality of life logging statement to hopefully save future us time.

Related Issue(s)

Fixes: https://github.com/gitpod-io/ops/issues/8805

How to test

Scale ws-manager to zero.
Rollout restart ws-proxy.
Check ws-proxy logs.

Release Notes

NONE

Documentation

Build Options:

  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish Options
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer Options
  • with-ee-license
  • with-dedicated-emulation
  • with-ws-manager-mk2
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated

Preview Environment Options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@kylos101 kylos101 requested a review from a team March 23, 2023 21:20
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label Mar 23, 2023
@kylos101 kylos101 changed the title [ws-proxy] provide a hint to our future selves [ws-proxy] log before attempting to dial ws-manager Mar 23, 2023
@roboquat roboquat merged commit 049ebe1 into main Mar 23, 2023
@roboquat roboquat deleted the kylos101/go-away-grpc branch March 23, 2023 22:29
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note-none size/XS team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants