Skip to content

[ws-proxy] log before attempting to dial ws-manager #17009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 23, 2023
Merged

[ws-proxy] log before attempting to dial ws-manager #17009

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions components/ws-proxy/cmd/run.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,9 @@ var runCmd = &cobra.Command{
grpcOpts := common_grpc.DefaultClientOptions()
grpcOpts = append(grpcOpts, dialOption)

log.Info("Attempting to dial ws-manager, it's a blocking call that retries...")
conn, err := grpc.Dial(wsm.Addr, grpcOpts...)
// you will never get here if ws-manager is crashing, instead the readiness check for ws-proxy will restart the pod
if err != nil {
log.WithError(err).Fatal("cannot connect to ws-manager")
}
Expand Down