remove date from input for cookieless hash (#18154)

jakobhero · web-flow · commit 3e8e55f9aa37 · 2023-07-14T02:37:30.000+08:00
diff --git a/components/server/src/analytics.ts b/components/server/src/analytics.ts
@@ -49,11 +49,9 @@ export function createCookielessId(ip?: string, ua?: string): string | number |
     if (!ip || !ua) {
         return "unidentified-user"; //use placeholder if we cannot resolve IP and user agent
     }
-    const date = new Date();
-    const today = `${date.getDate()}/${date.getMonth()}/${date.getFullYear()}`;
     return crypto
         .createHash("sha512")
-        .update(ip + ua + today)
+        .update(ip + ua)
         .digest("hex");
 }
 

Original file line number	Diff line number	Diff line change
`@@ -49,11 +49,9 @@ export function createCookielessId(ip?: string, ua?: string): string \| number \|`
`49`	`49`	`if (!ip \|\| !ua) {`
`50`	`50`	`return "unidentified-user"; //use placeholder if we cannot resolve IP and user agent`
`51`	`51`	`}`
`52`		`- const date = new Date();`
`53`		- const today = `${date.getDate()}/${date.getMonth()}/${date.getFullYear()}`;
`54`	`52`	`return crypto`
`55`	`53`	`.createHash("sha512")`
`56`		`- .update(ip + ua + today)`
	`54`	`+ .update(ip + ua)`
`57`	`55`	`.digest("hex");`
`58`	`56`	`}`
`59`	`57`