[Analytics] Remove date from input for cookieless hash #18154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakobhero
force-pushed
the
web-590
branch
3 times, most recently
from
47cf883 to
00a7e64
Compare
jakobhero
force-pushed
the
web-590
branch
2 times, most recently
from
3e6f7b4 to
1eb2a62
Compare
easyCZ
approved these changes
Jul 13, 2023
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Aligns the cookieless tracking on the webapp with the webapp, which allows us to calculate page visitor to signup conversion for cookieless tracked visitors on the website.
Related Issue(s)
Fixes WEB-590
How to test
This cannot be tested in the preview environment as the client IP is read from headers added by the google load balancer. What you can do is go to Segment's Trusted Debugger and ensure that there is a page event with
anonymousId: unidentified-user(which we default to when we don't have access to the client IP) when you open the preview environment. This ensures that our tracking didn't break because of the change.Documentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh/hold