[server] delete duplicate auth provider (#17651)

Author: svenefftinge

components/gitpod-db/src/auth-provider-entry.spec.db.ts

@@ -104,9 +104,9 @@ export class AuthProviderEntryDBSpec {
     }
 
     @test public async findByOrgId() {
-        const ap1 = this.authProvider({ id: "1", organizationId: "O1" });
-        const ap2 = this.authProvider({ id: "2", organizationId: "O1" });
-        const ap3 = this.authProvider({ id: "3", organizationId: "O2" });
+        const ap1 = this.authProvider({ id: "1", organizationId: "O1", host: "H1" });
+        const ap2 = this.authProvider({ id: "2", organizationId: "O1", host: "H2" });
+        const ap3 = this.authProvider({ id: "3", organizationId: "O2", host: "H1" });
 
         await this.db.storeAuthProvider(ap1, false);
         await this.db.storeAuthProvider(ap2, false);

components/gitpod-db/src/typeorm/migration/1684328022688-AuthProviderUniqueHostName.ts

@@ -0,0 +1,30 @@
+/**
+ * Copyright (c) 2023 Gitpod GmbH. All rights reserved.
+ * Licensed under the GNU Affero General Public License (AGPL).
+ * See License.AGPL.txt in the project root for license information.
+ */
+
+import { MigrationInterface, QueryRunner } from "typeorm";
+
+export class AuthProviderUniqueHostName1684328022688 implements MigrationInterface {
+    public async up(queryRunner: QueryRunner): Promise<void> {
+        // delete any duplicates
+        await queryRunner.query(`
+            DELETE FROM d_b_auth_provider_entry
+            WHERE id NOT IN (
+                SELECT id FROM (
+                    SELECT MIN(id) AS id
+                    FROM d_b_auth_provider_entry
+                    GROUP BY host
+                ) AS t
+            )
+        `);
+        // create constraint
+        await queryRunner.query(`
+            ALTER TABLE d_b_auth_provider_entry
+            ADD CONSTRAINT unique_host_by_org UNIQUE (host, organizationId)
+        `);
+    }
+
+    public async down(queryRunner: QueryRunner): Promise<void> {}
+}

components/server/src/auth/auth-provider-service.ts

@@ -33,19 +33,7 @@ export class AuthProviderService {
      */
     async getAllAuthProviders(exceptOAuthRevisions: string[] = []): Promise<AuthProviderParams[]> {
         const all = await this.authProviderDB.findAll(exceptOAuthRevisions);
-        const transformed = all.map(this.toAuthProviderParams.bind(this));
-
-        // as a precaution, let's remove duplicates
-        const unique = new Map<string, AuthProviderParams>();
-        for (const current of transformed) {
-            const duplicate = unique.get(current.host);
-            if (duplicate) {
-                log.warn(`Duplicate dynamic Auth Provider detected.`, { rawResult: all, duplicate: current.host });
-                continue;
-            }
-            unique.set(current.host, current);
-        }
-        return Array.from(unique.values());
+        return all.map((provider) => this.toAuthProviderParams(provider));
     }
 
     async getAllAuthProviderHosts(): Promise<string[]> {