[server] delete duplicate auth provider

[svenefftinge]

Description

Stumbled over this log message. Which is caused by two entries in d_b_auth_provider_entry with the same host. There is only this one duplicate case in the prdo DB and I don't know how it got there, but instead of always ignoring one entry we should enforce this on insert/update.

The message is logged because the actual config that is used alternates with every call.
And since we cache by host name it gets re-created every time.

gitpod/components/server/src/auth/host-context-provider-impl.ts

Lines 84 to 109 in 079d31e

	const existingContext = this.dynamicHosts.get(host);
	const existingConfig = existingContext && existingContext.authProvider.params;
	if (existingConfig && config.id === existingConfig.id) {
	const sameHost = config.host === existingConfig.host;
	if (!sameHost) {
	log.warn("Ignoring host update for dynamic Auth Provider: " + host, { config, existingConfig });
	continue;
	}
	const sameOwner = config.ownerId === existingConfig.ownerId;
	const sameStatus = config.status === existingConfig.status;
	const sameOAuthRevision =
	!!config.oauthRevision && existingConfig.oauthRevision === config.oauthRevision;
	if (sameOwner && sameStatus && sameOAuthRevision) {
	continue;
	}
	log.debug("Updating existing dynamic Auth Provider: " + host, { config, existingConfig });
	} else {
	log.debug("Creating new dynamic Auth Provider: " + host, { config });
	}
	const container = this.factory.createHostContext(config);
	if (container) {
	this.dynamicHosts.set(host, container);
	} else {
	log.warn("Did not update dynamic Auth Provider " + host, { config });
	}

Related Issue(s)

Fixes #

How to test

Documentation

Preview status

gitpod:summary

Build Options:

• /werft with-werft
  Run the build with werft instead of GHA
• leeway-no-cache
• /werft no-test
  Run Leeway with --dont-test

Publish Options

• /werft publish-to-npm
• /werft publish-to-jb-marketplace

Installer Options

• analytics=segment
• with-dedicated-emulation
• with-ws-manager-mk2
• workspace-feature-flags
  Add desired feature flags to the end of the line above, space separated

Preview Environment Options:

• /werft with-local-preview
  If enabled this will build install/preview
• /werft with-preview
• /werft with-large-vm
• /werft with-gce-vm
  If enabled this will create the environment on GCE infra
• with-integration-tests=all
  Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

/hold

[AlexTugarev]

nit: the middle SELECT id FROM (...) AS t seems to be redundant.
anyways, TIL how to delete duplicates 👍🏻

[AlexTugarev]

[components/gitpod-db:dbtest]   1) AuthProviderEntryDBSpec
[components/gitpod-db:dbtest]        findByOrgId:
[components/gitpod-db:dbtest]      QueryFailedError: ER_DUP_ENTRY: Duplicate entry 'i.8713187.xyz-O1' for key 'unique_host_by_org'

🙈 db-tests are failing

[svenefftinge]

/unhold