Skip to content

Commit ea6fd88

Browse files
authored
Ensure containers inherit stdio (#18828)
1 parent 9a38b60 commit ea6fd88

File tree

1 file changed

+6
-1
lines changed
  • components/docker-up/runc-facade

1 file changed

+6
-1
lines changed

components/docker-up/runc-facade/main.go

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,12 @@ func createAndRunc(runcPath string, log *logrus.Logger) error {
9090
// See here for more details on why retries are necessary.
9191
// https://github.com/gitpod-io/gitpod/issues/12365
9292
for i := 0; i <= RETRY; i++ {
93-
err = exec.Command(runcPath, os.Args[1:]...).Run()
93+
94+
cmd := exec.Command(runcPath, os.Args[1:]...)
95+
cmd.Stdin = os.Stdin
96+
cmd.Stderr = os.Stderr
97+
cmd.Stdout = os.Stdout
98+
err = cmd.Run()
9499

95100
if err != nil {
96101
log.WithError(err).Warn("runc failed")

0 commit comments

Comments
 (0)