Skip to content

Ensure containers inherit stdio #18828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Ensure containers inherit stdio #18828

merged 1 commit into from
Sep 27, 2023

Conversation

Furisto
Copy link
Member

@Furisto Furisto commented Sep 27, 2023

Description

Ensure that containers started through runc-facade inherit the stdio file descriptors of the calling process.

Summary generated by Copilot

🤖 Generated by Copilot at 0a1a5c0

Forward runc output to runc-facade in components/docker-up/runc-facade/main.go. This helps with troubleshooting and error handling for workspace container creation.

Related Issue(s)

Fixes ENG-900
Fixes #18814

How to test

  • Start docker container without these changes docker run alpine echo hello. There should be no output.
  • Start docker container with the fix. Output should be hello

Documentation

Preview status

gitpod:summary

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

@roboquat roboquat merged commit ea6fd88 into main Sep 27, 2023
@roboquat roboquat deleted the fo/fix-container-io branch September 27, 2023 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docker run emits no output without the --tty flag
3 participants