Skip to content

[ws-manager-mk2] Fix workspace container detection #16418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 27, 2023
Merged

[ws-manager-mk2] Fix workspace container detection #16418

merged 1 commit into from
Feb 27, 2023

Conversation

Furisto
Copy link
Member

@Furisto Furisto commented Feb 15, 2023

Description

Fix workspace container detection. Depends on #16413. Without working workspace container detection resource constraints will not be applied to the workspace container.

Related Issue(s)

n.a.

How to test

Release Notes

None

Build Options:

  • /werft with-github-actions
    Experimental feature to run the build with GitHub Actions (and not in Werft).
  • leeway-no-cache
    leeway-target=components:all
  • /werft no-test
    Run Leeway with --dont-test
Publish Options
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer Options
  • with-ee-license
  • with-slow-database
  • with-dedicated-emulation
  • with-ws-manager-mk2
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated

Preview Environment Options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@Furisto Furisto added team: workspace Issue belongs to the Workspace team feature: ws-manager-mk2 labels Feb 15, 2023
@Furisto Furisto requested a review from a team February 15, 2023 15:34
@Furisto Furisto self-assigned this Feb 15, 2023
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-fo-adv-4.2 because the annotations in the pull request description changed
(with .werft/ from main)

@kylos101
Copy link
Contributor

/hold

until #16413 is merged

@roboquat roboquat added size/XS and removed size/M labels Feb 27, 2023
@roboquat roboquat merged commit 1f89b92 into main Feb 27, 2023
@roboquat roboquat deleted the fo/adv-4 branch February 27, 2023 10:47
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production feature: ws-manager-mk2 release-note-none size/XS team: workspace Issue belongs to the Workspace team
Projects
No open projects
Status: In Validation
Development

Successfully merging this pull request may close these issues.

4 participants