Skip to content

[ws-manager-mk2] Ensure prebuilds can start and stop #16479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 27, 2023
Merged

Conversation

Furisto
Copy link
Member

@Furisto Furisto commented Feb 20, 2023

Description

Note: This depends on #16471

Ensures that prebuilds can initialize successfully (before storage access was missing) and stopping successfully (by ensuring workspaces enter stopped phase once backup has been taken and deleting the prebuild pod so that workspace CR deletion can be performed)

Related Issue(s)

n.a.

How to test

  • Create project in preview environment
  • Start prebuild
  • Prebuild should initialize and run successfully and enter stopped phase once completed. Afterwards the workspace CR should be deleted.

Release Notes

None

Build Options:

  • /werft with-github-actions
    Experimental feature to run the build with GitHub Actions (and not in Werft).
  • leeway-no-cache
    leeway-target=components:all
  • /werft no-test
    Run Leeway with --dont-test
Publish Options
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer Options
  • with-ee-license
  • with-slow-database
  • with-dedicated-emulation
  • with-ws-manager-mk2
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated

Preview Environment Options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@WVerlaek
Copy link
Member

WVerlaek commented Feb 23, 2023

/werft run with-preview=true with-wsman-mk2=true with-gce-vm=true

👍 started the job as gitpod-build-fo-mk2-prebuilds.3
(with .werft/ from main)

@WVerlaek
Copy link
Member

@Furisto could you also enable and update/add controller tests for headless workspaces here?

@roboquat roboquat added size/S and removed size/M labels Feb 27, 2023
@roboquat roboquat merged commit 12f3c91 into main Feb 27, 2023
@roboquat roboquat deleted the fo/mk2-prebuilds branch February 27, 2023 10:45
@roboquat roboquat added the deployed: workspace Workspace team change is running in production label Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: In Validation
Development

Successfully merging this pull request may close these issues.

4 participants