[ws-manager-mk2] Remove headless from status #16530
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylos101
reviewed
Feb 23, 2023
roboquat
added
release-note-none
and removed
do-not-merge/release-note-label-needed
labels
WVerlaek
force-pushed
the
wv/mk2-rm-headless-from-status
branch
from
f8306ca to
eb162f9
Compare
WVerlaek
force-pushed
the
wv/mk2-rm-headless-from-status
branch
from
eb162f9 to
d1360e5
Compare
roboquat
added
deployed: workspace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove
Headlessfrom the workspace status, and instead introduce aIsHeadless()function on theWorkspacetype which uses the spec to determine if it's headless. Fixes a race where the status might not yet be set after creation, causingHeadlessto be falseRelated Issue(s)
How to test
Release Notes
Documentation
Build Options:
Experimental feature to run the build with GitHub Actions (and not in Werft).
leeway-target=components:all
Run Leeway with
--dont-testPublish Options
Installer Options
Add desired feature flags to the end of the line above, space separated
Preview Environment Options:
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh