-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Extract a CheckboxInput component from onboarding flow #16545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
started the job as gitpod-build-bmh-checkbox-input-component.1 because the annotations in the pull request description changed |
/werft run with-preview=true 👍 started the job as gitpod-build-bmh-checkbox-input-component.3 |
@@ -21,7 +22,7 @@ export const InputField: FunctionComponent<Props> = memo(({ label, id, hint, err | |||
{label && ( | |||
<label | |||
className={classNames( | |||
"text-sm font-semibold dark:text-gray-400", | |||
"text-md font-bold dark:text-gray-400", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Slightly increasing size of input labels, and making them bold.
437352f
to
31dabfc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/hold in case you want feedback from design
/unhold |
Description
Extracts the checkbox input used in the onboarding flow to a
CheckboxInput
component and also creates aCheckboxInputField
that wraps a list of checkboxes in the same styling as other input type components do. This should allow us to use it as a field w/ a list of checkboxes, like the onboarding flow, or as a standalone checkbox like we do in other places.Other places in our UI use a
<CheckBox/>
component that I've referred to for some of the styles here, but plan on replacing those with this<CheckboxInput/>
component for consistency. There's a few things to figure out w/ some of our font sizing, weights, and colors for form-related components, so I'll leave that as a separate task.Related Issue(s)
Relates to #16511
How to test
Release Notes
Documentation
Build Options:
Experimental feature to run the build with GitHub Actions (and not in Werft).
leeway-target=components:all
Run Leeway with
--dont-test
Publish Options
Installer Options
Add desired feature flags to the end of the line above, space separated
Preview Environment Options:
If enabled this will build
install/preview
If enabled this will create the environment on GCE infra
Valid options are
all
,workspace
,webapp
,ide
,jetbrains
,vscode
,ssh