-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[baseserver] Initialize tracer with server #16586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
started the job as gitpod-build-mp-baseserver-tracer.1 because the annotations in the pull request description changed |
/werft run with-clean-slate-deployment=true 👍 started the job as gitpod-build-mp-baseserver-tracer.4 |
/werft run with-clean-slate-deployment=true 👍 started the job as gitpod-build-mp-baseserver-tracer.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM, deployment works and log look 👌 : ✔️
(although these big PRs that touch a gazillion .sum/.mod files scare me a bit 😬 )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. There are conflicts now - approving just so you don't have to chase down reviews after having resolved them
59b2b83
to
12d0016
Compare
/werft run 👍 started the job as gitpod-build-mp-baseserver-tracer.7 |
/werft run 👍 started the job as gitpod-build-mp-baseserver-tracer.8 |
/werft run recreate-vm 👍 started the job as gitpod-build-mp-baseserver-tracer.9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Workspace can be started in preview env
❓ But honeycomb shows nothing don't know how to verify it
gitpod /workspace/gitpod (mp/baseserver-tracer) $ kubectl get configmap otel-collector -n monitoring-satellite -o yaml | grep preview.name -C 3
processors:
attributes:
actions:
- key: 'preview.name'
value: mp-baseserver-tracer
action: insert
exporters:
So this change only binds the Tracer. We don't use it in the public-api yet so we won't yet have traces showing up |
/unhold |
Description
This change extends base-server to automatically initialize tracing as part of the server. It also adds a convenience method to retrieve the tracer with
server.Tracer()
rather than grabbing it from the globalopentracing.GlobalTracer()
namespace.Related Issue(s)
Fixes #
How to test
Release Notes
Documentation
Build Options:
Experimental feature to run the build with GitHub Actions (and not in Werft).
leeway-target=components:all
Run Leeway with
--dont-test
Publish Options
Installer Options
Add desired feature flags to the end of the line above, space separated
Preview Environment Options:
If enabled this will build
install/preview
If enabled this will create the environment on GCE infra
Valid options are
all
,workspace
,webapp
,ide
,jetbrains
,vscode
,ssh
/hold