Skip to content

[ws-manager-mk2] Enable tracing, add debug logs #16643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 6, 2023

Conversation

WVerlaek
Copy link
Member

@WVerlaek WVerlaek commented Mar 2, 2023

Description

  • Enable tracing for ws-manager-mk2
  • Add additional (debug) logging

Related Issue(s)

Part of #11416

How to test

View ws-manager-mk2 traces in EU jaeger instance. Deployed and tested from an ephemeral cluster

Release Notes

NONE

Documentation

Build Options:

  • /werft with-github-actions
    Experimental feature to run the build with GitHub Actions (and not in Werft).
  • leeway-no-cache
    leeway-target=components:all
  • /werft no-test
    Run Leeway with --dont-test
Publish Options
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer Options
  • with-ee-license
  • with-slow-database
  • with-dedicated-emulation
  • with-ws-manager-mk2
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated

Preview Environment Options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@WVerlaek WVerlaek self-assigned this Mar 2, 2023
@WVerlaek WVerlaek requested a review from a team March 2, 2023 19:35
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label Mar 2, 2023
@WVerlaek WVerlaek force-pushed the wv/mk2-traces-debug-logs branch from 4be28c2 to 663baaf Compare March 2, 2023 19:37
@kylos101
Copy link
Contributor

kylos101 commented Mar 6, 2023

@WVerlaek is a hold still needed? If yes, can you share why?

@WVerlaek
Copy link
Member Author

WVerlaek commented Mar 6, 2023

@kylos101 yes - as it's a stacked PR

@kylos101
Copy link
Contributor

kylos101 commented Mar 6, 2023

@kylos101 yes - as it's a stacked PR

@WVerlaek 🤦 got it. Can you share a link to something describing the stack?

@WVerlaek
Copy link
Member Author

WVerlaek commented Mar 6, 2023

@kylos101 it's these three PRs stacked in order:

they're individual PRs of fixes discovered during loadtesting iterations, but stacked as during loadtesting it requires a build that contains the changes of all these PRs.

Base automatically changed from wv/mk2-loadgen-fixes to main March 6, 2023 14:18
@roboquat roboquat added size/L and removed size/M labels Mar 6, 2023
@WVerlaek WVerlaek force-pushed the wv/mk2-traces-debug-logs branch from 663baaf to 3b5181e Compare March 6, 2023 14:27
@roboquat roboquat added size/M and removed size/L labels Mar 6, 2023
@roboquat roboquat merged commit 6694cf1 into main Mar 6, 2023
@roboquat roboquat deleted the wv/mk2-traces-debug-logs branch March 6, 2023 15:22
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note-none size/M team: workspace Issue belongs to the Workspace team
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants