[dashboard] query cache orgs #16685
[dashboard] query cache orgs #16685
Conversation
|
started the job as gitpod-build-sefftinge-optimize-team-retrieval-16235.1 because the annotations in the pull request description changed |
svenefftinge
force-pushed
the
sefftinge/optimize-team-retrieval-16235
branch
2 times, most recently
from
52a4331 to
61e78b9
Compare
|
/hold |
|
Unsure if this is caused by this change, or also exists on main, but creating a new team won't switch my context to that newly created team. |
|
Otherwise looks to work correctly, thanks for doing this. |
svenefftinge
force-pushed
the
sefftinge/optimize-team-retrieval-16235
branch
from
61e78b9 to
7d4110f
Compare
There was a problem hiding this comment.
This is great, thanks for doing this 😄 . Left a few pieces of feedback.
Halfway through I stopped commenting on the unneccessary ? in places (makes me wonder if there's a lint rule that can identify these we just don't have on. They don't hurt though, so def. a nit that would be better if a linter could let us know.
svenefftinge
force-pushed
the
sefftinge/optimize-team-retrieval-16235
branch
from
7d4110f to
67b1c3c
Compare
svenefftinge
force-pushed
the
sefftinge/optimize-team-retrieval-16235
branch
from
67b1c3c to
612c369
Compare
|
/unhold |
roboquat
added
deployed: webapp
| ? "text-red-600 dark:text-red-400 hover:text-red-800 dark:hover:text-red-300" | ||
| : "text-gray-400 dark:text-gray-200", | ||
| onClick: () => leaveTeamEnabled && removeTeamMember(m.userId), | ||
| onClick: () => | ||
| org.data?.isOwner && removeTeamMember(m.userId), |
There was a problem hiding this comment.
@svenefftinge this read like you would not be able to leave an org as a non-owner.
also, every owner would see "Remaining owner".
Before the change, this would only be shown for the last owner of an org.
There was a problem hiding this comment.
oh, yes. It should be that you cannot leave if you are the last owner.
There was a problem hiding this comment.
I've filed an issue #16753
Description
Introduces a custom hook for retrieving organizations backed by react query.
Related Issue(s)
Fixes #16235
How to test
Release Notes
Documentation
Build Options:
Experimental feature to run the build with GitHub Actions (and not in Werft).
leeway-target=components:all
Run Leeway with
--dont-testPublish Options
Installer Options
Add desired feature flags to the end of the line above, space separated
Preview Environment Options:
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh