-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add x-client
in ide-metrics component
#16701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
started the job as gitpod-build-hw-metrics-client.2 because the annotations in the pull request description changed |
db853fa
to
db4d047
Compare
started the job as gitpod-build-hw-metrics-client.5 because the annotations in the pull request description changed |
/werft run 👍 started the job as gitpod-build-hw-metrics-client.6 |
db4d047
to
25b2784
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks good, i did not try
/hold
unhold when are ready to merge
/unhold |
Description
Add
x-client
a global setting in ide-metricsTODOs
Related Issue(s)
Fixes #
How to test
Check also test results #16701 (comment)
ide-metrics
in preview env should correctly setupmetric_client
for supervisor public api metricsdebug mode
/metrics
endpoint at port 9500 should havemetric_client
field with vscodeRelease Notes
Documentation
Build Options:
Experimental feature to run the build with GitHub Actions (and not in Werft).
leeway-target=components:all
Run Leeway with
--dont-test
Publish Options
Installer Options
Add desired feature flags to the end of the line above, space separated
Preview Environment Options:
If enabled this will build
install/preview
If enabled this will create the environment on GCE infra
Valid options are
all
,workspace
,webapp
,ide
,jetbrains
,vscode
,ssh