[installer] Do not pull blobserve implementation into installer #16729
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
easyCZ
commented
Mar 8, 2023
| @@ -44,40 +44,6 @@ type BlobserveInlineVars struct { | |||
| SupervisorImage string `json:"supervisor"` | |||
| } | |||
|
|
|||
| type BlobSpace struct { | |||
There was a problem hiding this comment.
This is moved to the config package
|
I wonder should not we separate implementation from api via dedicated component like |
akosyakov
approved these changes
Mar 8, 2023
|
Given the necessary dependencies are already not included with this change, I don't think we necessarily need to introduce the api package for this. In some cases it could make sense, but here it'd just hold the config which seems unnecessary |
|
/unhold |
roboquat
added
deployed: IDE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
By referencing the
blobserve/pkg/blobserve, we were effectively pulling all of blobserve (and it's dependencies) directly as a dependency into the installer.This change moves the necessary config into the
blobserve/configsuch that we only depend on that, and not on the blobserve implementation packages (see removed deps in installer).This in turn does the following:
Related Issue(s)
Fixes #
How to test
CI passes
Release Notes
Documentation
Build Options:
Experimental feature to run the build with GitHub Actions (and not in Werft).
leeway-target=components:all
Run Leeway with
--dont-testPublish Options
Installer Options
Add desired feature flags to the end of the line above, space separated
Preview Environment Options:
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh