[server] Remove admin OTS create/use flow #16761
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
started the job as gitpod-build-mp-remove-admin-secret.1 because the annotations in the pull request description changed |
easyCZ
force-pushed
the
mp/remove-admin-secret
branch
from
f223445 to
0ce214c
Compare
geropl
reviewed
Mar 14, 2023
| if (!user) { | ||
| throw new Error("Cannot find builtin admin-user"); | ||
| } | ||
| user.blocked = false; |
There was a problem hiding this comment.
@easyCZ How is the admin-user unblocked in the new flow?
Just want to make sure this is not overlooked.
geropl
reviewed
Mar 14, 2023
| @@ -190,38 +190,6 @@ export class UserController { | |||
| } | |||
| }); | |||
|
|
|||
| router.get( | |||
There was a problem hiding this comment.
How do we login to a websession with the new credentials? Not set up, yet?
There was a problem hiding this comment.
geropl
approved these changes
Mar 14, 2023
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
No longer needed, as it's super-seeded by the admin-credentials file flow
Related Issue(s)
How to test
Release Notes
Documentation
Build Options:
Run the build with werft instead of GHA
leeway-target=components:all
Run Leeway with
--dont-testPublish Options
Installer Options
Add desired feature flags to the end of the line above, space separated
Preview Environment Options:
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh