[rebuild] decouple IDE env vars from registry-facade #16812
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
started the job as gitpod-build-ak-rebuild-ide-env.1 because the annotations in the pull request description changed |
|
@csweichel should we also clean up the logic in registry-facade handling GITPOD_ENV_ modifiers? Nobody besides IDEs were using them. Or does not matter? (with another PR when all images are updated though). |
akosyakov
force-pushed
the
ak/rebuild_ide_env
branch
2 times, most recently
from
42e2e0d to
f83a383
Compare
akosyakov
force-pushed
the
ak/rebuild_ide_env
branch
from
f83a383 to
3b8cdc8
Compare
|
I tested all possible cases with stable. All looks good. gp rebuild now also has proper env vars, eg PATH. |
|
/hold since the final image should be rebuilt to support VS Code Browser 1.76.1, it is fine to review though |
akosyakov
force-pushed
the
ak/rebuild_ide_env
branch
from
3b8cdc8 to
09c60f2
Compare
by moving in supervisor-ide-config.json
akosyakov
force-pushed
the
ak/rebuild_ide_env
branch
from
09c60f2 to
beb7514
Compare
|
/unhold rebased and fixed VS Code image |
akosyakov
commented
Mar 13, 2023
| @@ -6,5 +6,14 @@ | |||
| "http": { | |||
| "path": "version" | |||
| } | |||
| }, | |||
| "env": { | |||
There was a problem hiding this comment.
@filiptronicek you will need to adjust Xterm example after deployment
filiptronicek
approved these changes
Mar 13, 2023
roboquat
added
deployed: IDE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
by moving in supervisor-ide-config.json
It ensures proper IDE env vars in a workspace started by gp rebuild.
Related Issue(s)
Fixes #
How to test
Release Notes
Documentation
Build Options:
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish Options
Installer Options
Add desired feature flags to the end of the line above, space separated
Preview Environment Options:
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh