Skip to content

[rebuild] support desktop IDEs #16818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 17, 2023
Merged

[rebuild] support desktop IDEs #16818

merged 2 commits into from
Mar 17, 2023

Conversation

akosyakov
Copy link
Member

@akosyakov akosyakov commented Mar 13, 2023

Description

This PR enables support of VS Code Desktop and JB product in workspaces started by gp rebuild.

Related Issue(s)

Fixes #

How to test

  • Download the JB GW plugin build related to this branch in Dev Versions, and install it on the Gateway.
  • Ensures to upgrade Gitpod extension in VS Code Desktop to latest version.
  • Start a workspace with VS Code Desktop or IntelliJ.
  • Confirm that usual flow works.
    • VS Code Desktop
    • IntelliJ
  • Now start a workspace with gp rebuild and confirm that such flow works as well.
    • VS Code Desktop
    • IntelliJ

Release Notes

NONE

Documentation

Build Options:

  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish Options
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer Options
  • with-ee-license
  • with-dedicated-emulation
  • with-ws-manager-mk2
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated

Preview Environment Options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@iQQBot iQQBot force-pushed the ak/rebuild_desktop branch from cefb6bf to 9600152 Compare March 17, 2023 08:25
@gitpod-io gitpod-io deleted a comment from werft-gitpod-dev-com bot Mar 17, 2023
@gitpod-io gitpod-io deleted a comment from werft-gitpod-dev-com bot Mar 17, 2023
@gitpod-io gitpod-io deleted a comment from werft-gitpod-dev-com bot Mar 17, 2023
@iQQBot
Copy link
Contributor

iQQBot commented Mar 17, 2023

image

@iQQBot iQQBot marked this pull request as ready for review March 17, 2023 10:12
@iQQBot iQQBot requested a review from a team March 17, 2023 10:12
Copy link
Member Author

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iQQBot i cannot self approve. You can approve )

@roboquat roboquat merged commit 8e9f2c0 into main Mar 17, 2023
@roboquat roboquat deleted the ak/rebuild_desktop branch March 17, 2023 14:00
@roboquat roboquat added deployed: IDE IDE change is running in production deployed Change is completely running in production labels Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: IDE IDE change is running in production deployed Change is completely running in production release-note-none size/M team: IDE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants