Skip to content

[dashboard] give start workspace button focus #16826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 13, 2023
Merged

[dashboard] give start workspace button focus #16826

merged 1 commit into from
Mar 13, 2023

Conversation

svenefftinge
Copy link
Contributor

@svenefftinge svenefftinge commented Mar 13, 2023 •
edited
Loading

Description

  • Allow starting workspaces without using the mouse
  • Support all kinds of contextURLs

Related Issue(s)

Fixes #16754

How to test

Release Notes

NONE

Documentation

Build Options:

  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish Options
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer Options
  • with-ee-license
  • with-dedicated-emulation
  • with-ws-manager-mk2
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated

Preview Environment Options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@svenefftinge svenefftinge requested a review from a team March 13, 2023 14:22
@svenefftinge svenefftinge requested a review from gtsiolis as a code owner March 13, 2023 14:22
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-sefftinge-new-workspace-page-allow-16754.0 because the annotations in the pull request description changed
(with .werft/ from main)

@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Mar 13, 2023
easyCZ
easyCZ reviewed Mar 13, 2023
View reviewed changes
@svenefftinge svenefftinge force-pushed the sefftinge/new-workspace-page-allow-16754 branch from fc36392 to 1d90c3c Compare March 13, 2023 14:26
@svenefftinge
Copy link
Contributor Author

/unhold

@svenefftinge
Copy link
Contributor Author

/hold

@svenefftinge svenefftinge force-pushed the sefftinge/new-workspace-page-allow-16754 branch from 1d90c3c to 74d72d9 Compare March 13, 2023 16:49
@svenefftinge
Copy link
Contributor Author

/unhold

@roboquat roboquat merged commit 3d7a084 into main Mar 13, 2023
@roboquat roboquat deleted the sefftinge/new-workspace-page-allow-16754 branch March 13, 2023 16:52
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@easyCZ easyCZ easyCZ approved these changes

@gtsiolis gtsiolis Awaiting requested review from gtsiolis

Assignees
No one assigned
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/M team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[new workspace page] allow continue with enter
4 participants
@svenefftinge @easyCZ @vulkoingim @roboquat