Skip to content

Remove cgroups v1 from commons-go #16859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 17, 2023
Merged

Remove cgroups v1 from commons-go #16859

merged 2 commits into from
Mar 17, 2023

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Mar 15, 2023

Description

Gitpod only uses cgroups v2

Release Notes

NONE

Build Options:

  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish Options
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer Options
  • with-ee-license
  • with-dedicated-emulation
  • with-ws-manager-mk2
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated

Preview Environment Options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

Signed-off-by: Manuel de Brito Fontes <[email protected]>
Signed-off-by: Manuel de Brito Fontes <[email protected]>
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-aledbf-bye-cgroups-v1.2 because the annotations in the pull request description changed
(with .werft/ from main)

@aledbf aledbf marked this pull request as ready for review March 15, 2023 15:40
@aledbf aledbf requested a review from a team March 15, 2023 15:40
@aledbf aledbf requested a review from a team as a code owner March 15, 2023 15:40
@github-actions github-actions bot added team: workspace Issue belongs to the Workspace team team: staff-engineers labels Mar 15, 2023
@easyCZ
Copy link
Member

easyCZ commented Mar 15, 2023

Why do we have the cgroups package in common-go in the first place, given it looks to only be used by ws-daemon?

@roboquat roboquat merged commit 95feb1a into main Mar 17, 2023
@roboquat roboquat deleted the aledbf/bye-cgroups-v1 branch March 17, 2023 14:25
@roboquat roboquat added the deployed: workspace Workspace team change is running in production label Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: workspace Workspace team change is running in production release-note-none size/L team: staff-engineers team: workspace Issue belongs to the Workspace team
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants