[tests] Move workspace integration tests to Github Actions #16872
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roboquat
added
size/XL
release-note-none
and removed
do-not-merge/release-note-label-needed
labels
WVerlaek
reviewed
Mar 16, 2023
There was a problem hiding this comment.
if we merge this PR to main and then iterate on it afterwards lets keep the scripts for werft for the time being until the GHA workflow is tested
| PREVIEW_ENV_DEV_SA_KEY: ${{ secrets.GCP_CREDENTIALS }} | ||
| PREVIEW_NAME: ${{ needs.configuration.outputs.name }} | ||
| run: | | ||
| set -euo pipefail |
There was a problem hiding this comment.
it might be cleaner to keep this script in a separate bash file, and run that file here. That way we keep e.g. syntax highlighting, bash linting, etc.
There was a problem hiding this comment.
Will do in a follow-on PR, or, if I have trouble getting having the tests run general. So, expect another PR. ;)
kylos101
force-pushed
the
kylos101/wks-integ-fix
branch
from
c10f86c to
47084ed
Compare
WVerlaek
reviewed
Mar 16, 2023
There was a problem hiding this comment.
It's visible from a workspace, thanks Github extension!
WVerlaek
approved these changes
Mar 16, 2023
roboquat
added
deployed: workspace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Triggering tests via werft continues to break / is brittle. Let's move to Github Actions, copying from IDE team, but manage Workspace secret via GCP Secrets Manager.
As background, Workspace integration tests last worked as of March 10. They may have been broke here.
Related Issue(s)
Fixes # n/a
How to test
Merge this to main, and then test.
@vulkoingim , is there a better way to test?
@iQQBot how do you iterate with your Github Actions for Gitpod? From a fork?
Release Notes
Documentation
Build Options:
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish Options
Installer Options
Add desired feature flags to the end of the line above, space separated
Preview Environment Options:
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh