Skip to content

[server] Fix file provider accept header #16881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 16, 2023
Merged

Conversation

easyCZ
Copy link
Member

@easyCZ easyCZ commented Mar 16, 2023

Description

The old accept header is not listed in Github's media types, the new one is

Related Issue(s)

Fixes #

How to test

Release Notes

NONE

Documentation

Build Options:

  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish Options
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer Options
  • with-ee-license
  • with-dedicated-emulation
  • with-ws-manager-mk2
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated

Preview Environment Options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@easyCZ easyCZ requested a review from a team March 16, 2023 14:31
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Mar 16, 2023
@@ -70,7 +70,7 @@ export class GithubFileProvider implements FileProvider {
if (typeof response.data === "string") {
return response.data;
}
log.warn("GithubFileProvider.getFileContent – unexpected response type.", {
log.warn("GithubFileProvider.getFileContent – unexpected response type.", {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this had an NBSP, replaced with space

Copy link
Member

@AlexTugarev AlexTugarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran the test /workspace/gitpod/components/server/src/github/github-file-provider.spec.ts, still works, so 👍🏻

@roboquat roboquat merged commit 8390cac into main Mar 16, 2023
@roboquat roboquat deleted the mp/github-accept-header branch March 16, 2023 16:13
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/XS team: webapp Issue belongs to the WebApp team
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants