-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[dashboard] Guard subscribeToStripe against multiple calls #16890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
started the job as gitpod-build-gpl-subscription-race.1 because the annotations in the pull request description changed |
db9fe5f
to
1770fca
Compare
components/dashboard/src/components/UsageBasedBillingConfig.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't have a chance to test this on staging, as the fe dev header doesn't seem to be working for me there. I had a suggestion for the way we're using state and useEffect() though.
components/dashboard/src/components/UsageBasedBillingConfig.tsx
Outdated
Show resolved
Hide resolved
components/dashboard/src/components/UsageBasedBillingConfig.tsx
Outdated
Show resolved
Hide resolved
components/dashboard/src/components/UsageBasedBillingConfig.tsx
Outdated
Show resolved
Hide resolved
Uh, that's bad, it should! |
1770fca
to
05d6a16
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change look good to me. It worked nicely so far.
Let's verify on staging after merging.
Did that already. 😉 But yeah, it's cheap enough, let's do it! |
Description
Related Issue(s)
Fixes #16524
How to test
Release Notes
Documentation
Build Options:
Run the build with werft instead of GHA
Run Leeway with
--dont-test
Publish Options
Installer Options
Add desired feature flags to the end of the line above, space separated
Preview Environment Options:
If enabled this will build
install/preview
If enabled this will create the environment on GCE infra
Valid options are
all
,workspace
,webapp
,ide
,jetbrains
,vscode
,ssh