[supervisor] fix open access control not working when git permission … #16987
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
started the job as gitpod-build-hw-fix-access-control.1 because the annotations in the pull request description changed |
akosyakov
approved these changes
Mar 23, 2023
…missed - Update `runAsGitpodUser` to append correct env - Fix .gitignore make whole supervisor component unsearchable
mustard-mh
force-pushed
the
hw/fix-access-control
branch
from
b195590 to
1d92c50
Compare
|
All good /unhold |
roboquat
added
deployed: IDE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[supervisor] fix open access control not working when git permission missed
runAsGitpodUserto append correct envRelated Issue(s)
Fixes internal chat
How to test
Preview env https://hw-fix-acc7a9a838b10.preview.gitpod-dev.com/workspaces
/user/integrationsto remove all optional permission of gitgit pushOpen Access Controlnotification and click should go to right place (unless you blocked pop-up)Release Notes
Documentation
Build Options:
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish Options
Installer Options
Add desired feature flags to the end of the line above, space separated
Preview Environment Options:
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh