[e2e] Support and fixes for mk2 e2e tests #16990
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WVerlaek
commented
Mar 23, 2023
| @@ -1050,7 +1057,7 @@ func watchStopWorkspaceAndFindSnapshot(t *testing.T, ctx context.Context, instan | |||
| if lastStatus.Conditions.HeadlessTaskFailed != "" { | |||
| return "", nil, errors.New("unexpected HeadlessTaskFailed condition") | |||
| } | |||
| if lastStatus == nil || lastStatus.Conditions == nil || lastStatus.Conditions.VolumeSnapshot == nil { | |||
There was a problem hiding this comment.
VolumeSnapshot isn't set in mk2
WVerlaek
commented
Mar 23, 2023
Comment on lines
-32
to
35
| for var in WITH_WS_MANAGER_MK2 WITH_DEDICATED_EMU WITH_EE_LICENSE ANALYTICS WORKSPACE_FEATURE_FLAGS; do | ||
| for var in WSMANAGER_MK2 WITH_DEDICATED_EMU WITH_EE_LICENSE ANALYTICS WORKSPACE_FEATURE_FLAGS; do | ||
| input_var="INPUT_${var}" | ||
| if [[ -n "${!input_var:-}" ]];then | ||
| export GITPOD_${var}=${!input_var} |
There was a problem hiding this comment.
deploy-gitpod.sh is expecting GITPOD_WSMANAGER_MK2
WVerlaek
commented
Mar 23, 2023
| @@ -366,7 +366,8 @@ func (wsm *WorkspaceManagerServer) StopWorkspace(ctx context.Context, req *wsman | |||
| ws.Status.SetCondition(workspacev1.NewWorkspaceConditionStoppedByRequest(gracePeriod.String())) | |||
| return nil | |||
| }) | |||
| if err != nil { | |||
| // Ignore NotFound errors, workspace has already been stopped. | |||
| if err != nil && status.Code(err) != codes.NotFound { | |||
There was a problem hiding this comment.
now matches mk1's behaviour
Furisto
approved these changes
Mar 24, 2023
|
/hold |
|
/unhold |
|
/hold still blocking! ugh. |
kylos101
force-pushed
the
wv/mk2-e2e-tests-2
branch
from
6e4069f to
f386dfe
Compare
kylos101
force-pushed
the
wv/mk2-e2e-tests-2
branch
from
f386dfe to
0bac28a
Compare
|
Tide is yielding this error. 🤔 @vulkoingim @mads-hartmann , any ideas? Restarting tide did not help. Rebasing with main. 🤷 |
|
😅 |
roboquat
added
deployed: workspace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
WS_MANAGER_MK2=trueenv varRelated Issue(s)
How to test
WS_MANAGER_MK2=trueRelease Notes
Documentation
Build Options:
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish Options
Installer Options
Add desired feature flags to the end of the line above, space separated
Preview Environment Options:
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh