Skip to content

[dashboard] Fix "history is undefined" on Ctrl+O #16995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2023
Merged

Conversation

geropl
Copy link
Member

@geropl geropl commented Mar 23, 2023

Description

We got errors like this:
image

This PR ensures the Router context is present before we use it with useHistory().

Related Issue(s)

Fixes #16994

How to test

Release Notes

Fix Ctrl/Cmd+O (Shortcut for "New Workspace" modal)

Documentation

Build Options:

  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish Options
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer Options
  • with-ee-license
  • with-dedicated-emulation
  • with-ws-manager-mk2
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated

Preview Environment Options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@easyCZ
Copy link
Member

easyCZ commented Mar 23, 2023

My new favourite javascript error. It's not Javascript's design history fault, because history is undefined

@geropl geropl requested a review from selfcontained March 23, 2023 13:35
@roboquat roboquat merged commit a28bde6 into main Mar 24, 2023
@roboquat roboquat deleted the gpl/16994-ctrl-o branch March 24, 2023 17:13
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note size/XS team: webapp Issue belongs to the WebApp team
Projects
Status: In Validation
Development

Successfully merging this pull request may close these issues.

[dashboard] StartWorkspace modal: Ctrl + O not working
4 participants