Skip to content

[ws-manager-mk2] Report content init/dispose failures #17015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2023

Conversation

WVerlaek
Copy link
Member

Description

Report content init/dispose failures in the workspace status.

Fixes the TestMissingBackup e2e test.

Related Issue(s)

Part of #11416

How to test

Tested by modifying ws-daemon to return an init (1) and dispose (2) error:

image

image

Release Notes

NONE

Documentation

Build Options:

  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish Options
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer Options
  • with-ee-license
  • with-dedicated-emulation
  • with-ws-manager-mk2
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated

Preview Environment Options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@WVerlaek WVerlaek requested a review from a team March 24, 2023 10:29
@WVerlaek WVerlaek self-assigned this Mar 24, 2023
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label Mar 24, 2023
@WVerlaek WVerlaek force-pushed the wv/mk2-report-content-failure-status branch from e078be2 to 8c60a63 Compare March 24, 2023 10:33
@kylos101 kylos101 force-pushed the wv/mk2-e2e-tests-2 branch from f386dfe to 0bac28a Compare March 24, 2023 22:36
Base automatically changed from wv/mk2-e2e-tests-2 to main March 24, 2023 22:42
@roboquat roboquat added size/L and removed size/M labels Mar 24, 2023
@WVerlaek WVerlaek force-pushed the wv/mk2-report-content-failure-status branch from 8c60a63 to d8d652f Compare March 27, 2023 09:02
@roboquat roboquat added size/M and removed size/L labels Mar 27, 2023
@WVerlaek
Copy link
Member Author

/unhold

@roboquat roboquat merged commit c14a25c into main Mar 27, 2023
@roboquat roboquat deleted the wv/mk2-report-content-failure-status branch March 27, 2023 15:22
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note-none size/M team: workspace Issue belongs to the Workspace team
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants