Skip to content

[ws-manager-mk2] Garbage collect workspaces #17021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2023
Merged

[ws-manager-mk2] Garbage collect workspaces #17021

merged 1 commit into from
Mar 24, 2023

Conversation

Furisto
Copy link
Member

@Furisto Furisto commented Mar 24, 2023

Description

Old workspaces (identified by having no workspace state file) will be garbage collected after 1 hour. This takes care of situations where we fail to remove the workspace content after backup e.g. because ws-daemon has been restarted.

Related Issue(s)

n.a.

How to test

  • Open workspace in preview environment
  • SSH into node and delete the workspace state file from disk
  • The garbage collection age has been modified in the preview environment so the workspace should be garbage collected after 2 minutes.

Release Notes

None

Documentation

Build Options:

  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish Options
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer Options
  • with-ee-license
  • with-dedicated-emulation
  • with-ws-manager-mk2
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated

Preview Environment Options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@Furisto Furisto added team: workspace Issue belongs to the Workspace team feature: ws-manager-mk2 labels Mar 24, 2023
@Furisto Furisto requested a review from a team March 24, 2023 14:16
@Furisto Furisto self-assigned this Mar 24, 2023
@roboquat roboquat merged commit 8871aed into main Mar 24, 2023
@roboquat roboquat deleted the fo/housekeeping branch March 24, 2023 17:18
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production feature: ws-manager-mk2 release-note-none size/L team: workspace Issue belongs to the Workspace team
Projects
No open projects
Status: In Validation
Development

Successfully merging this pull request may close these issues.

3 participants