Skip to content

[server] Fix userService.deauthorize to disallow disconnecting the last auth provider #17022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2023

Conversation

geropl
Copy link
Member

@geropl geropl commented Mar 24, 2023

Description

Related Issue(s)

Fixes #

How to test

Release Notes

NONE

Documentation

Build Options:

  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish Options
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer Options
  • with-ee-license
  • with-dedicated-emulation
  • with-ws-manager-mk2
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated

Preview Environment Options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-gpl-fix-deauthorize.1 because the annotations in the pull request description changed
(with .werft/ from main)

Copy link
Member

@AlexTugarev AlexTugarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It worked as expected. Having just a single built-in provider connected with will throw an error, when trying to deauthorize.

Screenshot 2023-03-24 at 17 58 15

Having two built-in providers connected with, will handle the request as expected.

Screenshot 2023-03-24 at 17 58 55

@geropl geropl marked this pull request as ready for review March 24, 2023 17:10
@geropl geropl requested a review from a team March 24, 2023 17:10
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Mar 24, 2023
@roboquat roboquat merged commit 72a58dd into main Mar 24, 2023
@roboquat roboquat deleted the gpl/fix-deauthorize branch March 24, 2023 17:19
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/XS team: webapp Issue belongs to the WebApp team
Projects
Status: In Validation
Development

Successfully merging this pull request may close these issues.

3 participants