[common-go] Rate limiting on booleans and composite keys #17026
Merged
+131
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WVerlaek
force-pushed
the
wv/composite-rate-limit-key
branch
from
663ad2a to
a32278c
Compare
WVerlaek
commented
Mar 27, 2023
Comment on lines
+89
to
+93
| fields := strings.Split(key, ",") | ||
| paths := make([][]string, len(fields)) | ||
| for i, field := range fields { | ||
| paths[i] = strings.Split(field, ".") | ||
| } |
There was a problem hiding this comment.
Extracting these string splits to outside the returned function improves performance by ~60%:
// OLD:
// BenchmarkFieldAccessKey_String-32 5800192 215.1 ns/op
// BenchmarkFieldAccessKey_Composite-32 3239696 371.9 ns/op
// NEW:
// BenchmarkFieldAccessKey_String-32 9338356 127.8 ns/op
// BenchmarkFieldAccessKey_Composite-32 5505349 217.8 ns/op
WVerlaek
force-pushed
the
wv/composite-rate-limit-key
branch
from
9ba5720 to
3502d81
Compare
WVerlaek
force-pushed
the
wv/composite-rate-limit-key
branch
from
3502d81 to
9bd36a1
Compare
akosyakov
approved these changes
Mar 28, 2023
easyCZ
approved these changes
Mar 28, 2023
|
/hold blocking merge pool |
|
started the job as gitpod-build-wv-composite-rate-limit-key.5 because the annotations in the pull request description changed |
|
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
foo.bar,foo.bazRelated Issue(s)
How to test
Run unit tests and benchmarks. Tested single and composite keys in a preview env
Release Notes
Documentation
Build Options:
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish Options
Installer Options
Add desired feature flags to the end of the line above, space separated
Preview Environment Options:
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh