Replace watch with builder.ControllerManagedBy #17028
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cannot start job - please talk to whoever's in charge of your Werft installation |
|
cannot start job - please talk to whoever's in charge of your Werft installation |
aledbf
force-pushed
the
aledbf/node-labeler-watch
branch
6 times, most recently
from
27ea764 to
454d502
Compare
aledbf
force-pushed
the
aledbf/node-labeler-watch
branch
from
670308e to
9a6fe23
Compare
aledbf
force-pushed
the
aledbf/node-labeler-watch
branch
from
d3b0724 to
000da2a
Compare
aledbf
commented
Mar 25, 2023
| err = ctrl.NewControllerManagedBy(mgr). | ||
| Named("pod-watcher"). | ||
| For(&corev1.Pod{}, builder.WithPredicates(filterPredicate)). | ||
| WithOptions(controller.Options{MaxConcurrentReconciles: 1}). |
There was a problem hiding this comment.
If we set RequeueAfter with MaxConcurrentReconciles > 1, the retry does not respect the wait time.
Now that we don't sleep in the reconcile loop, setting MaxConcurrentReconciles is not a problem
aledbf
force-pushed
the
aledbf/node-labeler-watch
branch
from
42e5c8d to
72c0f31
Compare
aledbf
commented
Mar 25, 2023
| @@ -258,11 +258,6 @@ func updateLabel(label string, add bool, nodeName string, client client.Client) | |||
| return err | |||
| } | |||
|
|
|||
| _, hasLabel := node.Labels[label] | |||
There was a problem hiding this comment.
This was not checking the value of the label and the check was done before calling this function
aledbf
force-pushed
the
aledbf/node-labeler-watch
branch
from
72c0f31 to
13de063
Compare
Signed-off-by: Manuel de Brito Fontes <[email protected]>
aledbf
force-pushed
the
aledbf/node-labeler-watch
branch
from
ccb426c to
9b199da
Compare
Furisto
approved these changes
Mar 27, 2023
roboquat
added
deployed: workspace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Switch to a controller to not use the low-level watch abstraction.
A side effect of this change is the reduction in ~20s to add the required node labels
Release Notes
Build Options:
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish Options
Installer Options
Add desired feature flags to the end of the line above, space separated
Preview Environment Options:
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh