-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Update go-redis to v9 #17037
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update go-redis to v9 #17037
Conversation
started the job as gitpod-build-aledbf-redis.5 because the annotations in the pull request description changed |
@aledbf why the upgrade? I recall related to Dedicated. For example, maybe fixes an intermittent bug on image pull? I will try to test briefly in workspace-preview. |
@kylos101 this has nothing to do with dedicated but with how the library cancels the context in code. |
rebase with main is 👍 , preview env is online |
/hold We should test briefly in an ephemeral cluster; I will budget time to do later this week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from hold, 👍
/unhold While inspecting logs to observe cluster behavior: |
👋 @gitpod-io/engineering-ide this is ready for review now, I shared results of a loadgen test (above), and am GTG from a Workspace perspective. |
Description
The main change in v9 is the removal of asynchronous cancellation based on the context timeout
Release Notes
Build Options:
Run the build with werft instead of GHA
Run Leeway with
--dont-test
Publish Options
Installer Options
Add desired feature flags to the end of the line above, space separated
Preview Environment Options:
If enabled this will build
install/preview
If enabled this will create the environment on GCE infra
Valid options are
all
,workspace
,webapp
,ide
,jetbrains
,vscode
,ssh