Skip to content

Update go-redis to v9 #17037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 30, 2023
Merged

Update go-redis to v9 #17037

merged 2 commits into from
Mar 30, 2023

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Mar 26, 2023

Description

The main change in v9 is the removal of asynchronous cancellation based on the context timeout

Release Notes

NONE

Build Options:

  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish Options
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer Options
  • with-dedicated-emulation
  • with-ws-manager-mk2
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated

Preview Environment Options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-aledbf-redis.5 because the annotations in the pull request description changed
(with .werft/ from main)

@kylos101
Copy link
Contributor

@aledbf why the upgrade? I recall related to Dedicated. For example, maybe fixes an intermittent bug on image pull? I will try to test briefly in workspace-preview.

@aledbf
Copy link
Member Author

aledbf commented Mar 29, 2023

@kylos101 this has nothing to do with dedicated but with how the library cancels the context in code.
https://github.com/redis/go-redis/blob/master/CHANGELOG.md

@kylos101
Copy link
Contributor

Rebased with main, will add redis to preview (if it isn't there), reconfigure registry-facade to use, and run a brief test.

Note: I tried installing with this build version in workspace-preview, which I think has redis, but got:
image

@kylos101
Copy link
Contributor

rebase with main is 👍 , preview env is online

@kylos101
Copy link
Contributor

/hold

We should test briefly in an ephemeral cluster; I will budget time to do later this week.

Copy link
Contributor

@kylos101 kylos101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from hold, 👍

@kylos101
Copy link
Contributor

@kylos101
Copy link
Contributor

No issues starting workspaces with loadgen or running manually.

image

@kylos101
Copy link
Contributor

/unhold

:shipit:

While inspecting logs to observe cluster behavior:
#17099
https://linear.app/gitpod/issue/WKS-30/registry-facade-node-labeler-check-yields-tls-handshake-error-from

@kylos101
Copy link
Contributor

👋 @gitpod-io/engineering-ide this is ready for review now, I shared results of a loadgen test (above), and am GTG from a Workspace perspective.

@roboquat roboquat merged commit 55fb6b3 into main Mar 30, 2023
@roboquat roboquat deleted the aledbf/redis branch March 30, 2023 20:24
@roboquat roboquat added the deployed: IDE IDE change is running in production label Apr 3, 2023
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: IDE IDE change is running in production deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note-none size/M team: IDE team: workspace Issue belongs to the Workspace team
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants