Skip to content

[usage] Implement charge dispute handling - WEB-94 #17039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 11, 2023

Conversation

easyCZ
Copy link
Member

@easyCZ easyCZ commented Mar 27, 2023

Description

Uses the User & Team service to block owners when a dispute is raised.

  • Uses go-vcr to record a Stripe response with a hook to drop authorization

Related Issue(s)

How to test

Release Notes

NONE

Documentation

Build Options:

  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish Options
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer Options
  • with-dedicated-emulation
  • with-ws-manager-mk2
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated

Preview Environment Options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

/hold

@easyCZ easyCZ changed the title [usage] Add OnChargeDispute rpc definition [usage] Implement charge dispute handling Mar 27, 2023
@easyCZ easyCZ force-pushed the mp/usage-implement-charge-dispute branch 3 times, most recently from ddffc88 to ecd6251 Compare March 30, 2023 12:48
@roboquat roboquat added size/XXL and removed size/L labels Mar 30, 2023
@atduarte
Copy link
Contributor

atduarte commented Apr 4, 2023

/reviewpad summarize

@reviewpad
Copy link

reviewpad bot commented Apr 4, 2023

AI-Generated Pull Request Summary: This pull request includes changes to multiple files, mostly removing redundant whitespaces and cleaning up unnecessary lines. Significant updates include adding new dependencies, modifying the configuration logic, and updating the billing system to handle charge disputes. New utility functions ClusterAddress and ClusterURL have been added to the net.go file for working with service addresses in a Kubernetes cluster, while multiple test functions have been introduced to support added functionality. Overall, these changes improve code style consistency, maintainability, and enhance the billing system's handling of charge disputes.

@gitpod-io gitpod-io deleted a comment from reviewpad bot Apr 4, 2023
@easyCZ easyCZ changed the base branch from main to mp/usage-server-address April 4, 2023 09:24
@easyCZ
Copy link
Member Author

easyCZ commented Apr 4, 2023

/hold for dependency

@easyCZ easyCZ marked this pull request as ready for review April 4, 2023 09:25
@easyCZ easyCZ requested a review from a team April 4, 2023 09:25
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Apr 4, 2023
@easyCZ easyCZ force-pushed the mp/usage-server-address branch from 3ee2554 to 25c83c9 Compare April 4, 2023 09:29
@easyCZ easyCZ force-pushed the mp/usage-implement-charge-dispute branch from fb523cb to 1ad0dc9 Compare April 4, 2023 09:29
Copy link
Contributor

@svenefftinge svenefftinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Also nice testing setup!
FWIW it doesn't feel great to have a bidirectional dep between server and usage but I guess we'll have to live with it given our architecture. 🤷

@easyCZ easyCZ force-pushed the mp/usage-server-address branch from 25c83c9 to 1bac657 Compare April 11, 2023 08:29
@easyCZ easyCZ changed the title [usage] Implement charge dispute handling [usage] Implement charge dispute handling - WEB-94 Apr 11, 2023
@easyCZ
Copy link
Member Author

easyCZ commented Apr 11, 2023

FWIW it doesn't feel great to have a bidirectional dep between server and usage but I guess we'll have to live with it given our architecture. 🤷

Agree. I'm hoping we can fix the "leadership election" part and merge usage with PAPI. It doesn't remove the bi-directionality, but at least it consolidates it closer to the desired architecture.

Base automatically changed from mp/usage-server-address to main April 11, 2023 08:42
@easyCZ easyCZ force-pushed the mp/usage-implement-charge-dispute branch from 1ad0dc9 to 7479e03 Compare April 11, 2023 08:53
@easyCZ easyCZ requested a review from a team April 11, 2023 09:21
@easyCZ
Copy link
Member Author

easyCZ commented Apr 11, 2023

/unhold

@roboquat roboquat merged commit f4babd3 into main Apr 11, 2023
@roboquat roboquat deleted the mp/usage-implement-charge-dispute branch April 11, 2023 13:55
@roboquat roboquat added deployed: IDE IDE change is running in production deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: IDE IDE change is running in production deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/XXL team: IDE team: webapp Issue belongs to the WebApp team
Projects
Status: In Validation
Development

Successfully merging this pull request may close these issues.

5 participants