Sign in with SSO #17055
Merged
Sign in with SSO #17055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
started the job as gitpod-build-at-next-sso-login.4 because the annotations in the pull request description changed |
AlexTugarev
force-pushed
the
at/next-sso-login
branch
3 times, most recently
from
014b7cc to
65767e9
Compare
Reusing existing parts: * `/complete-auth` page of Dashbaord to forward results of authN flows running in a modal * Adding preliminary UI to the Login view: Org-slug and simple button.
AlexTugarev
force-pushed
the
at/next-sso-login
branch
from
65767e9 to
586d1e0
Compare
roboquat
added
release-note-none
and removed
do-not-merge/release-note-label-needed
labels
|
/hold because of competition in #17052 |
selfcontained
approved these changes
Mar 28, 2023
|
Really looking forward to this! 😍 One question: How do we guard the login endpoints/APIs on gitpod.io? Is it worth having a feature flag? Or do we already lock those, maybe transitively, by controlling settings SSO config via API? |
|
I think we're good to go here. Let's iterate on it based on this state. Just made another round of testing to have a good answer for Gero's ask:
|
|
/hold cancel |
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a
Sign in with SSOoption to the Login screen.This feature is guarded by a hidden flag, as it's hard to use feature flags for that. One can enable it by
Related Issue(s)
Fixes #15967
Fixes WEB-37
How to test
localStorage.setItem("gitpod-ui-experiments", `{"ssoLogin": true}`)Sign in with SSObuttonRelease Notes
Documentation
Build Options:
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish Options
Installer Options
Add desired feature flags to the end of the line above, space separated
Preview Environment Options:
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh