Skip to content

[workspace] Increase rollout speed of daemonsets #17060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 28, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions install/installer/pkg/common/common.go
Original file line number Diff line number Diff line change
Expand Up @@ -818,3 +818,14 @@ func ExperimentalWebappConfig(ctx *RenderContext) *experimental.WebAppConfig {
func WithLocalWsManager(ctx *RenderContext) bool {
return ctx.Config.Kind == config.InstallationFull
}

func DaemonSetRolloutStrategy() appsv1.DaemonSetUpdateStrategy {
maxUnavailable := intstr.Parse("20%")

return appsv1.DaemonSetUpdateStrategy{
Type: appsv1.RollingUpdateDaemonSetStrategyType,
RollingUpdate: &appsv1.RollingUpdateDaemonSet{
MaxUnavailable: &maxUnavailable,
},
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ func daemonset(ctx *common.RenderContext) ([]runtime.Object, error) {
},
},
},
UpdateStrategy: common.DaemonSetRolloutStrategy(),
},
}}, nil
}
Original file line number Diff line number Diff line change
Expand Up @@ -320,6 +320,7 @@ func daemonset(ctx *common.RenderContext) ([]runtime.Object, error) {
Tolerations: common.GPUToleration(),
},
},
UpdateStrategy: common.DaemonSetRolloutStrategy(),
},
}}, nil
}
1 change: 1 addition & 0 deletions install/installer/pkg/components/ws-daemon/daemonset.go
Original file line number Diff line number Diff line change
Expand Up @@ -327,6 +327,7 @@ func daemonset(ctx *common.RenderContext) ([]runtime.Object, error) {
},
Spec: podSpec,
},
UpdateStrategy: common.DaemonSetRolloutStrategy(),
},
}}, nil
}