[ws-manager-mk2] Remember existing workspaces after a restart #17066
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WVerlaek
commented
Mar 28, 2023
Comment on lines
+305
to
+307
| if disposeErr != nil { | ||
| wsc.emitEvent(ws, "Backup", fmt.Errorf("failed to backup workspace: %w", disposeErr)) | ||
| } |
There was a problem hiding this comment.
fixes a Backup failure event being generated even on successful backups, as the error is wrapped and therefore always non-nil, so a failure event gets generated
WVerlaek
commented
Mar 28, 2023
| @@ -148,6 +148,11 @@ func (r *WorkspaceReconciler) Reconcile(ctx context.Context, req ctrl.Request) ( | |||
| func (r *WorkspaceReconciler) actOnStatus(ctx context.Context, workspace *workspacev1.Workspace, workspacePods corev1.PodList) (ctrl.Result, error) { | |||
| log := log.FromContext(ctx) | |||
|
|
|||
| if workspace.Status.Phase != workspacev1.WorkspacePhaseStopped && !r.metrics.containsWorkspace(workspace) { | |||
| // If the workspace hasn't stopped yet, and we don't know about this workspace yet, remember it. | |||
| r.metrics.rememberWorkspace(workspace, nil) | |||
There was a problem hiding this comment.
this will construct a metricState for this workspace with the assumption that any existing conditions have already been reported on.
E.g. if the workspace already has a BackupFailed condition, the metricState will assume it's already been reported before ws-manager-mk2 restarted and not report it again.
We could potentially loose a few events due to this during a restart, but the alternative is re-reporting every condition for all existing workspaces after ws-manager-mk2 restarts
aledbf
approved these changes
Mar 29, 2023
roboquat
added
deployed: workspace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug where existing workspaces would not get metrics recorded after ws-manager-mk2 restarts, due to
rememberWorkspaceonly being called for newly created workspacesRelated Issue(s)
How to test
Tested in a load test
Release Notes
Documentation
Build Options:
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish Options
Installer Options
Add desired feature flags to the end of the line above, space separated
Preview Environment Options:
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh