[common-go] force set configcat log level to error #17067
Conversation
|
started the job as gitpod-build-pd-configcat-log-error.1 because the annotations in the pull request description changed |
|
started the job as gitpod-build-pd-configcat-log-error.2 because the annotations in the pull request description changed |
|
started the job as gitpod-build-pd-configcat-log-error.3 because the annotations in the pull request description changed |
|
/hold unblock merge queue |
|
Would you be able to provide more context as to why? The log level is intentionally setup to mirror the log level of the rest of the system, so changing the system log level with The configcat debug logs can be rather verbose in practice. |
|
It always logs as Error because of this https://github.com/gitpod-io/gitpod/blob/pd/configcat-log-error/components/common-go/experiments/configcat.go#L96 |
@easyCZ It's not true, configcat does not always use this, some times, it direct uses the expected use is like this https://github.com/configcat/go-sdk/blob/218279137924bf88947c8cc8120aec6287b33104/v7/eval.go#L63-L68 but it is not in everywhere e.g. https://github.com/configcat/go-sdk/blob/218279137924bf88947c8cc8120aec6287b33104/v7/config_fetcher.go#L247-L248 this one will direct call |
|
let's merge this first, if we have any problem, we can revert anyway /unhold |
Description
[common-go] force set configcat log level to error
Related Issue(s)
Fixes #
How to test
Release Notes
Documentation
Build Options:
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish Options
Installer Options
Add desired feature flags to the end of the line above, space separated
Preview Environment Options:
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh